-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: if preprocessor is async function and doesn't return a content t… #3387
Conversation
@johnjbarton please take a look |
✅ Build karma 2431 completed (commit 3f9ca408af by @anthony-redFox) |
✅ Build karma 33 completed (commit 3f9ca408af by @anthony-redFox) |
✅ Build karma 32 completed (commit 3f9ca408af by @anthony-redFox) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test for the normal async path where done() is not called.
…hen await donePromise
5d471ea
to
e55a258
Compare
@johnjbarton Thanks for review. Add new unit tests and comments |
✅ Build karma 2432 completed (commit 23033eaa42 by @anthony-redFox) |
✅ Build karma 33 completed (commit 23033eaa42 by @anthony-redFox) |
✅ Build karma 34 completed (commit 23033eaa42 by @anthony-redFox) |
…hen await donePromise