fix(runner): remove explicit error on all tests failed #3369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@johnjbarton Can we expect it in the next release? |
|
The github project CI appveyor needs to be fixed. |
- there are failOnFailingTestSuite and failOnEmptyTestSuite, so in this there is no neccesity Fixes karma-runner#3367
ilgonmic
force-pushed
the
no-explicit-error-on-all-tests-failed
branch
from
2794308
to
c2255db
Compare
|
@johnjbarton Seems that appveyor is triggered by GitHub's PR |
|
Or github is not dealing with the status now. This worked until a couple of weeks ago. |
|
@johnjbarton Maybe it will be useful |
|
retriggering appveyor with new config |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are failOnFailingTestSuite and failOnEmptyTestSuite, so in this there is no necessity
Fixes #3367