feat(preprocessor): preprocessor_priority execution order. #3303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnjbarton
force-pushed
the
preprocessor-priority
branch
from
7c65eb8
to
24dfb97
Compare
johnjbarton
force-pushed
the
preprocessor-priority
branch
2 times, most recently
from
dc9cd1e
to
a6002c3
Compare
johnjbarton
force-pushed
the
preprocessor-priority
branch
from
a6002c3
to
8894fbc
Compare
Between 3.x and 4.x we moved from combineLists to underscore.union in preprocessor. Apparently combineLists was incorrect: the order of preprocessing changed in some cases. Conceptually the order ought to depend upon the preprocessor, not the file. Implement config.preprocessor_priority['preprocessor-name'] = priority, higher means run earlier. Default priority is 0. Add back compat API for karma-browserify. Update docs.
johnjbarton
force-pushed
the
preprocessor-priority
branch
from
8894fbc
to
2812c6f
Compare
|
PTAL, now the tests pass and I've squashed the commits |
kyliau
approved these changes
Aug 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Between 3.x and 4.x we moved from combineLists to underscore.union in preprocessor.
Apparently combineLists was incorrect: the order of preprocessing changed in some cases.
Conceptually the order ought to depend upon the preprocessor, not the file.
Implement config.preprocessor_priority['preprocessor-name'] = priority, higher means run earlier.
Default priority is 0.
Check that your description matches the automatic change-log format:
http://karma-runner.github.io/latest/dev/git-commit-msg.html
then delete this reminder.