-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: stringify error on 'Cannot convert a Symbol value to a string' #2990
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
CLAs look good, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the first characters of your description to
fix(common):
Please add to your commit description
Fixes #2856
Please rebase and push again to trigger a retest.
fc0d4ab
to
5763c5e
Compare
@johnjbarton fixed issues test are passing tell me if you need anything more |
Thanks! |
There were problems with using console.log while running test that resulted in errors like:
or
Related to issue: #2856
I have also noticed that i need to remove
static/context.js
andstatic/karma.js
from.gitignore
and include them in the repo so that this fix worked on my repository copy but didn't include it here as I am not sure they are built at some later point.