Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disconnecting a browser sends browser_error event to reporters #2853

Open
segrey opened this issue Oct 24, 2017 · 0 comments
Open

Disconnecting a browser sends browser_error event to reporters #2853

segrey opened this issue Oct 24, 2017 · 0 comments

Comments

@segrey
Copy link
Contributor

segrey commented Oct 24, 2017

Expected behaviour

Disconnecting a browser shouldn't send browser_error to reporters.

Actual behaviour

Start karma server and capture a browser manually. Once a test run is done, close the browser manually.
As a result, reporter's onBrowserError method is called back with error='Disconnectedundefined': https://github.com/karma-runner/karma/blob/v1.7.1/lib/browser.js#L40

Seems there is no much sense in this event after the test run. The problem is that reporters should filter out such events as it's not an error.

Environment Details

  • Karma version (output of karma --version): 1.7.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant