fix(runner): remove explicit error on all tests failed (#3369)

* fix(runner): remove explicit error on all tests failed - there are failOnFailingTestSuite and failOnEmptyTestSuite, so in this there is no neccesity Fixes #3367 * test(unit): Remove test
karma-runner · Oct 10, 2019 · f8005c6 · f8005c6
1 parent f2eba15
commit f8005c6
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 11 deletions.
diff --git a/lib/browser.js b/lib/browser.js
@@ -87,10 +87,6 @@ class Browser {
       this.setState(CONNECTED)
       this.lastResult.totalTimeEnd()
 
-      if (!this.lastResult.success) {
-        this.lastResult.error = true
-      }
-
       this.emitter.emit('browsers_change', this.collection)
       this.emitter.emit('browser_complete', this, result)
 

diff --git a/test/unit/browser.spec.js b/test/unit/browser.spec.js
@@ -213,13 +213,6 @@ describe('Browser', () => {
 
       expect(browser.lastResult.totalTime).to.equal(2)
     })
-
-    it('should error the result if zero tests executed', () => {
-      browser.state = Browser.STATE_EXECUTING
-      browser.onComplete()
-
-      expect(browser.lastResult.error).to.equal(true)
-    })
   })
 
   describe('onDisconnect', () => {