fix(cli): print UserAgent string verbatim if from an unknown browser

output UserAgent string verbatim instead of the unhelpful "Other 0.0.0 (Other)"
karma-runner · Jun 9, 2015 · 9d97226 · 9d97226
1 parent 1c233a0
commit 9d97226
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lib/helper.js b/lib/helper.js
@@ -5,7 +5,7 @@ var useragent = require('useragent')
 
 exports.browserFullNameToShort = function (fullName) {
   var agent = useragent.parse(fullName)
-  return agent.toAgent() + ' (' + agent.os + ')'
+  return agent.family !== 'Other' ? agent.toAgent() + ' (' + agent.os + ')' : fullName;
 }
 
 exports.isDefined = function (value) {

diff --git a/test/unit/browser.spec.coffee b/test/unit/browser.spec.coffee
@@ -64,6 +64,11 @@ describe 'Browser', ->
       browser = new Browser 'id', fullName, collection, emitter, socket
       expect(browser.toString()).to.equal 'Chrome 16.0.912 (Mac OS X 10.6.8)'
 
+    it 'should return verbatim user agent string for unrecognized browser', ->
+      fullName = 'NonexistentBot/1.2.3'
+      browser = new Browser 'id', fullName, collection, emitter, socket
+      expect(browser.toString()).to.equal 'NonexistentBot/1.2.3'
+
 
   #==========================================================================
   # Browser.onKarmaError