Broken functionalities when karax used with grammarly or languagetool (and possibly other extensions)

[pietroppeter]

this came up in the forum today and it is only reported as an issue in nimforum (nim-lang/nimforum#303), but it is probably better also to have it here, since it is an issue to be fixed in karax.

In short:

• extensions like grammarly or languagetool modify the dom and can corrupt nodes owned by karax
• karax implemented functionalities fail as a result

we do still miss:

• an understanding on how other virtual dom frameworks handle this case

we could probably benefit from:

• a smaller reproducible example (other than working dircetly with nimforum)

also, what is the "knete" approach that @Araq was referring to in the linked nimforum issue?

[Araq]

"Knete" is the working title for "Karax's DSL without the DOM diffing algorithm". The DSL simply produces real DOM nodes. Unfortunately this brings back all of the downsides of heavily state based programming. But it's still something I think is worthwhile to look into.

[geotre]

Normally the dom looks like this:

The extension inserts elements alongside the textarea:

Causing exception

The exception is triggered by one of the doAssert same(...) calls (e.g. 1, 2, 3). I'm not sure which it is exactly because the forum is compiled with an older copy of Karax.

[geotre]

Can reproduce the issue with something like this:

import std/dom
include pkg/karax/prelude

var val: cstring

proc draw: VNode =
  buildHtml(tdiv):
    textarea:
      proc onkeyup (ev: Event, n: VNode) =
        val = n.value
    p: text val

setRenderer draw, clientPostRenderCallback=proc =
  document.getElementById("ROOT").appendChild(document.createElement("p"))

Basically anything that adds elements as a descendant of the Karax root node

[Araq]

Well you can diactivate the assertions and see if it works out...

[geotre]

@pietroppeter this should be fixed now, do you want to test and close the issue?

[pietroppeter]

hi, well, I was not suffering from that bug, I opened the issue to give visibility to this problem (and apparently it worked! ;)). People that are known to me to suffer from this issue are @tsoj (opened the original issue), and, as I learned today from discord, also @ringabout. Others that could help test this out?

[ringabout]

It can be closed; ref nim-lang/nimforum#335

[pietroppeter]

thanks!