Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

karate-ui enhancements part 2 #482

Closed
vmchukky opened this issue Aug 2, 2018 · 6 comments
Closed

karate-ui enhancements part 2 #482

vmchukky opened this issue Aug 2, 2018 · 6 comments
Assignees

Comments

@vmchukky
Copy link
Contributor

vmchukky commented Aug 2, 2018

Add support for

  1. resizing of featurePanel, rawContentPanel (vertical) and varsPanel (horizontal)
  2. http request/response shown as addressable grid (clicking on method step to highlight corresponding row as mentioned in #306 | Ravinder | Adding Accordian Panel for step of type "method". #325 (comment))
@vmchukky
Copy link
Contributor Author

vmchukky commented Aug 11, 2018

@ptrthomas please review #495 at your convenience

@ptrthomas
Copy link
Member

@vmchukky there's this big commit that dropped:
#444 (comment)

so I have wired the UI to the new model objects, I think it is working - but the old off-by-one errors may have been re-introduced. if you get a chance - do take a look

@vmchukky
Copy link
Contributor Author

@ptrthomas will take a look

@vmchukky
Copy link
Contributor Author

@ptrthomas #444 is shaping up pretty good, I didn't find any major issues in UI. I have one small PR (applied on top of latest cukexit branch in my fork), please review #515 at your convenience.

@ptrthomas
Copy link
Member

@vmchukky this helps - thanks !

@ptrthomas
Copy link
Member

closing and we can open a new one for 0.9.0 onwards

@ptrthomas ptrthomas removed this from the 0.9.0 milestone Nov 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants