Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export's output file encoded in operating system encoding but not UTF-8 #77

Open
partment opened this issue Feb 18, 2020 · 9 comments
Open
Labels
bug Something isn't working will be fixed in the next relase fix is already done and will be included in the next release
Milestone

Comments

@partment
Copy link

Sorry for my bad English.

I'm using windows 10 x64 set with Traditional Chinese language and UTC+8 timezone.

With RcloneBrowser, the "Export" feature will output a file encoded in BIG5 which is designed to normally display Traditional Chinese. (Buggy condition)

But BIG5 has a problem with Japanese, causing some of my filenames turn into unreadable words.

With rclone command-line, rclone tree will output a file encoded in UTF-8. (Normal condition)

We all know that UTF-8 is now the standard.

@kapitainsky kapitainsky added the bug Something isn't working label Feb 18, 2020
@kapitainsky
Copy link
Owner

Definitely will investigate and try to fix - must be some Qt characters encoding magic.

@partment
Copy link
Author

Definitely will investigate and try to fix - must be some Qt characters encoding magic.

I've submitted a PR.

@kapitainsky
Copy link
Owner

Brilliant! I am not planning another release soon but tell me what OS you are on and I will release updated version for you.

@partment
Copy link
Author

Brilliant! I am not planning another release soon but tell me what OS you are on and I will release updated version for you.

I've already built for myself! :)

@kapitainsky
Copy link
Owner

Cool! It will then end up in the next release.

@kapitainsky kapitainsky added the will be fixed in the next relase fix is already done and will be included in the next release label Feb 18, 2020
@partment
Copy link
Author

partment commented Feb 18, 2020

It took me some times to set up the developing environment.
Don't forget to close this issue after next release.

@kapitainsky
Copy link
Owner

I have merged it to testing branch - I keep new things there for some time until tested.

@partment
Copy link
Author

partment commented Feb 18, 2020

According to my tests, this fix also works on csv format and successfully outputs Japanese without any exceptions or errors.

@kapitainsky
Copy link
Owner

UTF-8 should be standard for such output - agree. I missed it as not using often non western alphabet.

@kapitainsky kapitainsky added this to the 1.9.0 milestone Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working will be fixed in the next relase fix is already done and will be included in the next release
Projects
None yet
Development

No branches or pull requests

2 participants