Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Violations of SRP principles #17

Open
aditya23k opened this issue Mar 25, 2023 · 0 comments
Open

Violations of SRP principles #17

aditya23k opened this issue Mar 25, 2023 · 0 comments

Comments

@aditya23k
Copy link

  1. This code is definitely violating the Open Closed Principle. It has to be modified if there is any change in the value of the objects.

  2. The class invoice lacks a default constructor.

  3. Has the characteristics of a God Class with multiple methods

These are the only violations I see so far. I have been reviewing the lectures once again to get a better understanding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aditya23k