Ab webgl filter for resize #4426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'ab-webgl-filters-resize' of http://github.com/kangax/fabric.js into ab-webgl-filters-resize
Merged
thiagocunha
pushed a commit
to thiagocunha/fabric.js
that referenced
this pull request
Nov 18, 2019
* test another version * a working webgl resize * broke blur" * broke blur" * a working webgl resize * better cache shader * no dist * better * better2 * fixed tests * linting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic implementation, it works out pretty well. Had to get inspiration here and there, nothing was working, at the end i mixed the approach used with blur and the approach we were using with cpu lanczos filter to get a nice automatic shader.
Comparing between this lanzcos 3 lobes and pica one on a scale ratio of 0.1875
pica library results:
this results:
