Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed to dataurl export #3314

Merged
merged 2 commits into from
Oct 2, 2016
Merged

changed to dataurl export #3314

merged 2 commits into from
Oct 2, 2016

Conversation

asturur
Copy link
Member

@asturur asturur commented Oct 2, 2016

close #3152

-reverted the retinaScaling as multiplier change
-removed cropped logic and used viewportTransform
-use this.interactive = false to avoid draw border of active objects

The actual implementation was effectively producing a double size canvas for retina enabled devices, creating problems to low memory devices as ipads.

@asturur asturur merged commit 49c7858 into master Oct 2, 2016
@asturur asturur deleted the dataurlandretina branch October 2, 2016 17:53
var origWidth = this.getWidth(),
origHeight = this.getHeight(),
scaledWidth = (cropping.width || this.getWidth()) * multiplier,
scaledHeight = (cropping.width || this.getHeight()) * multiplier,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For scaledHeight, this should be cropping.height (not cropping.width).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue on resize canvas, and then generate data url
2 participants