Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change borderScaleFactor behaviour (#2930) #3154

Merged
merged 1 commit into from
Aug 11, 2016
Merged

Change borderScaleFactor behaviour (#2930) #3154

merged 1 commit into from
Aug 11, 2016

Conversation

sdvg
Copy link
Contributor

@sdvg sdvg commented Aug 10, 2016

See discussion in #2930

I think a multiplication makes much more sense here to cover all use cases. My use case for example is to render a 2px border.

@sdvg
Copy link
Contributor Author

sdvg commented Aug 10, 2016

I just figured out that I could just have used 0.5 🙈
Anyway, I think a multiplier is easier to grasp :)

@asturur
Copy link
Member

asturur commented Aug 11, 2016

I agree.
I was keeping this feature for 2.0 because is a back incompatible change. But i also think that this feature is so unpopular that no one will complain.
closes #2930

@asturur asturur merged commit c0f5dc3 into fabricjs:master Aug 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdvg @asturur