Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a not stateful canvas to fire object:modified at end of transform. #2890

Merged
merged 10 commits into from
Apr 13, 2016
Merged

Allow a not stateful canvas to fire object:modified at end of transform. #2890

merged 10 commits into from
Apr 13, 2016

Conversation

asturur
Copy link
Member

@asturur asturur commented Apr 13, 2016

Need some manual testing.

The problem is this can fire if the object is dragged around and left in same place it was before dragging.

Closes #2362
closes #1927

@asturur
Copy link
Member Author

asturur commented Apr 13, 2016

needs major rework.
Actually rotating, skew, scale moving fire even when the object is locked on those actions.

I will add a property to current transform to detect if something happened during transform.
target.Moving is good for that.

@asturur asturur changed the title Allow a not sattteful canvas to fire object:modified at end of transform. Allow a not stateful canvas to fire object:modified at end of transform. Apr 13, 2016
@asturur
Copy link
Member Author

asturur commented Apr 13, 2016

I added some more booleans to our boolean salad that was in the scaling and skewing events.
Now we should be able to understand when a transformation modified the object or not and fire the proper event and object:modified.

A this point stateful could be defaulted to false, since saving and checking the object stateProperties is needed just for advanced features. But being a breaking change i will not change it now.

@asturur asturur merged commit 37b2099 into fabricjs:master Apr 13, 2016
@asturur asturur deleted the stateful branch April 13, 2016 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stateful: false doesn't fire object:modified lockRotation and object:modified event
1 participant