Svg viewport transform fixes #2642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update to master
|
fixed also shadow tests. |
|
@kangax ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the property svgViewportTransformation does not produce correct output if set to false.
The option should ignore viewportTransform but it produce also a smaller svg.
This PR also separate the width and heigth from the viewbox and centralize the viewport handling in the svgHeader where the viewbox parameter is.
current BUG on fabricjs.com kitchensink viewport set to [1.5, 0, 0, 2, -100, 100]
svg output is correct.
Now we set canvas.svgViewportTransformation = false;
and svg output is:
instead of correct output that should be this:
This because the function is dividing width and heigth of the svg to zoom back to 1.
Now also is possible to export svg desired size:
canvas.toSVG({width: '500mm', height: '500mm'});canvas.toSVG({width: 300, height: 1500});this will produce svg of desired dimension without changing aspect ratio.