Fix itext onInput with selected text #2502
Conversation
Remove cancelOnInput logic, a normal e.preventDefault + stopPropagation is enough. Take in account already selected text when deciding how much text we are inserting during input event
|
unified removeStyleObject for itext and textbox |
|
@kangax those are failing for node4. Should i do something? |
|
@asturur yeah, Fabric is failing on Node 4.x for some reason. @LinusU any idea what this is? (https://travis-ci.org/kangax/fabric.js/jobs/82422214#L584) I thought this was supposed to be fixed in 1.2.9 but apparently something is still wrong? Would appreciate if you could give some pointers! |
|
should we not update also jsdom? i read sonewhere that to use node4 you beed jsdom higher than 6.3 |
|
anyway this PR would be ready like it is if you do not see anything strange |
|
@kangax Hmm, that is very strange, here is a recent build from us that uses the same version of node which works. https://travis-ci.org/Automattic/node-canvas/jobs/82633575 It's strange that all libraries gives the same error as well... |
|
We are using a old version of jsdom. may it be the problem? |
Fix itext onInput with selected text
Remove cancelOnInput logic, a normal e.preventDefault + stopPropagation is enough.
Take in account already selected text when deciding how much text we are inserting during input event
closes #2451