-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skew #2482
Skew #2482
Conversation
synct to master
cmon....
|
@kangax ready to merge! |
* @param {Array} a transformMatrix | ||
* @return {Object} Components of transform | ||
*/ | ||
qrDecompone: function(a) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's decompone?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that function to normalize the control box
Mathematically is calle QR decomposition, and it's done on linear transform matrices.
Is not directly necessary for skewing, but is necessary to decompone the transformation, also is an handy tool for expert users that need to do something with transformMatrix.
We will use it later, it was already in the source.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I don't think there's such word as decompone so let's change to decompose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mmm it is italian. i will put it in english.
Skew functionality with no merge conflict.
Still have to put in all the tests.