Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skew #2482

Merged
merged 5 commits into from
Sep 17, 2015
Merged

Skew #2482

merged 5 commits into from
Sep 17, 2015

Conversation

asturur
Copy link
Member

@asturur asturur commented Sep 17, 2015

Skew functionality with no merge conflict.
Still have to put in all the tests.

@asturur
Copy link
Member Author

asturur commented Sep 17, 2015

cmon....
"Expected points but got points" what he expects me to do?
Is point some kind of reserved word?

Expected points but got points, at src/util/misc.js :
   105 |    /**
   106 |     * Returns coordinates of points's bounding rectangle (left, top, width, height)
   107 |     * @param {Array} points, 4 points array
------------------------------^
   108 |     * @return {Object} Object with left, top, width, height properties
   109 |     */

@asturur
Copy link
Member Author

asturur commented Sep 17, 2015

@kangax ready to merge!

* @param {Array} a transformMatrix
* @return {Object} Components of transform
*/
qrDecompone: function(a) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's decompone?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that function to normalize the control box
Mathematically is calle QR decomposition, and it's done on linear transform matrices.
Is not directly necessary for skewing, but is necessary to decompone the transformation, also is an handy tool for expert users that need to do something with transformMatrix.

We will use it later, it was already in the source.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I don't think there's such word as decompone so let's change to decompose?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmm it is italian. i will put it in english.

kangax added a commit that referenced this pull request Sep 17, 2015
Add global support for skewing
@kangax kangax merged commit 6d99aaf into fabricjs:master Sep 17, 2015
@asturur asturur deleted the skew2 branch September 18, 2015 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants