fix getScrollLeftTop #2128
Merged
fix getScrollLeftTop #2128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
http://jsfiddle.net/asturur/6sksLp30/12/ i added more complex scroll option and simpler function. it works good |
|
after a brief discussion in #1821 i think we can merge this. |
|
We need a failing test in misc/position |
|
In the fabricjs.com? I can replicate this if needed: |
|
Yep, on fabrics.com. Just so that we can have a full set of functional tests to makes sure scrolling and all the other cases work. |
|
cannot wait to play with jekyll again.... 🍶 |
|
to reproduce same problem i need an iframe, is this ok for you? |
|
of course :) |
|
Here is PR with test for it, it is failing actually. |
|
+changelog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
original fiddle
http://jsfiddle.net/mcannon/6sksLp30/3/
In the fiddle there is a particular situation of fixed absolute and scrollabled divs.
modified fiddle with fabric 1.5.0 ad ovverridden function.
http://jsfiddle.net/6sksLp30/11/
Need some more testing with all the combination of scrollable div absolute and fixed position.
closes #1821