-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some headers are incorrectly parsed #2660
Comments
Thanks for reporting @aaronleopold ! Sorry but I'm not adding a lot here but just labeling it according to our new Contribution Guide and issue flow. It seems already got into Now in order to advance to Thank you and sorry that this comment is not a complete solution (yet). |
Hey 👋 no worries! When you ask for a failing test, are you asking for a code change that literally adds a failing test somewhere? Sorry if that seems an obvious question haha just want to clarify. If so, I can probably find time next weekend to do so. However, my playground link has a tentative fix underneath the reproduction, so at that point if I'm already issuing a PR would it just be preferred to make the fix directly? |
Yes exactly. |
Hello, we have the same errors and after some debug we understand that it was on graphql-inspector and we found this issue created. |
Sorry this fell off my radar since I didn't have time to wait for the outlined process because of a work requirement (and try not to work too much on the weekends 😅). I'll try to create the PR with the failing CI and followup with a correcting commit, but if you (@AdelELHAIBA-Akeneo) need the fix sooner my reproduction had a tentative fix you can use if you have the time to do what @Urigo outlined above |
Issue workflow progress
Progress of the issue based on the
Contributor Workflow
Describe the bug
I am trying to add an
Origin
header to command, but my server is picking up an incorrect header. For example, if I run:graphql-inspector introspect http://localhost:5500/api --header 'Origin: http://localhost:5500/api' --write schema.graphql
The header value that gets passed to my server is almost correct:
I believe the issue is here: https://github.com/kamilkisiela/graphql-inspector/blob/master/packages/commands/commands/src/index.ts#L51-L55
To Reproduce Steps to reproduce the behavior:
Expected behavior
Environment:
@graphql-inspector/cli
: ^4.0.2graphql
:^16.8.1
Additional context
Here is a basic reproduction using the linked logic above:
https://www.typescriptlang.org/play?#code/MYewdgzgLgBAhgJwOYRgXhgbwFAzzACwFM4ATIhALhgG1d8GAiAeQQEsk2xqCooAHSgHohAGxDA4ogiGiUArIvmMANPTwBdbAF9s2UUVjEyFVBkzb4qAEpFQCUgB5o7MEhUwXXJAD4A3HoAZiAIMAAUoJBGJOShIIHwyBAAdMaxAJRY6jCR0LRgcAC2RB7JZQBuUgCuRBAa6IQxFMkQ-KJsUGEA5JRd6QHZaaY0BcX1GJWiNSkAViBc3X0Buti5IAbJ4khhQwgQ6XoGsEggIKQAEk17DRZWMLb2Tl5uHs++A8GhEeB5uzDxiRQqSumRwDFysBGRRKMDKyUm03GjRMCBabQ63V6-T0DBOZ0uKIgULGDQRtWShTg-DCYRcmTQPk8UFRzLYhTC6XSyTmCx6Sx0ejWGy2YTxFyu+yAA
The text was updated successfully, but these errors were encountered: