Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I've lost my FAB #117

Closed
immanuelfodor opened this issue Nov 13, 2020 · 5 comments
Closed

I've lost my FAB #117

immanuelfodor opened this issue Nov 13, 2020 · 5 comments
Labels

Comments

@immanuelfodor
Copy link

Hi, somewhere at or after the latest rewrite, my FAB button got lost, and I haven't found it since then. It's not in the DOM, so I don't think it's being blocked by a plugin. I've added a pinned post in my Shaarli to link to the Add Shaare form, this is how I circumvented this issue so far to be able to add new links from the web. Could you please check where did the FAB go? 😃

@kalvn
Copy link
Owner

kalvn commented Nov 28, 2020

If by FAB button you mean the button to add new links, yes, it's related to issue #118

I just need to get an alternative from Shaarli dev team and I'll publish a fix.

@kalvn kalvn added the bug label Nov 28, 2020
@immanuelfodor
Copy link
Author

Yup, it's the Floating Action Button aka. FAB: https://material.io/components/buttons-floating-action-button :)

Thank you!

@pascollin
Copy link

In page.header.html $_PAGE variable seems empty
{$displayAddNewLinkIcon=(($is_logged_in || $openshaarli) && in_array($PAGE, array('linklist', 'tools', 'tag.cloud', 'tag.list', 'picwall', 'daily')))}
Dirty workaround : replace this line by the following :
{$displayAddNewLinkIcon=(($is_logged_in || $openshaarli))}
Now the button is displayed on all pages when logged in.

@immanuelfodor
Copy link
Author

It was previously fixed here, so this workaround is like a revert: #115 (comment)

@immanuelfodor
Copy link
Author

I've rebuilt my Shaarli using the support-v012 branch, and now the FAB is working again just as before. Thank you for the unnoticed changes in November :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants