Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-10598): add streamId to PKAdOptions #77

Merged
merged 1 commit into from
Aug 12, 2021
Merged

fix(FEC-10598): add streamId to PKAdOptions #77

merged 1 commit into from
Aug 12, 2021

Conversation

SivanA-Kaltura
Copy link
Contributor

@SivanA-Kaltura SivanA-Kaltura commented Aug 12, 2021 •
edited
Loading

Description of the Changes

Taking the value of streamId from the SDK's LOADED event and adding it to PKAdOptions.
Solves FEC-10598.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans requested a review from a team August 12, 2021 07:43
@SivanA-Kaltura SivanA-Kaltura merged commit f7487c5 into master Aug 12, 2021
@SivanA-Kaltura SivanA-Kaltura deleted the FEC-10598-expose-stream-id branch August 12, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yairans yairans yairans approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SivanA-Kaltura @yairans