feat(FEC-11475): create service manager that allows registration and accessing of services #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…accessing of services
RoyBregman
requested review from
yairans,
JonathanTGold,
OrenMe,
semarche-kaltura and
SivanA-Kaltura
5 tasks
yairans
previously approved these changes
Aug 12, 2021
RoyBregman
added a commit
to kaltura/kaltura-player-js
that referenced
this pull request
Aug 16, 2021
…accessing of services (#477) service provider was moved from ui repo (was known there as managers) to KP to enable cross service registration and accessing changes were also in: UI PR - kaltura/playkit-js-ui#630 Timeline PR - kaltura/playkit-js-timeline#4 IMA - kaltura/playkit-js-ima#205 IMA-DAI - kaltura/playkit-js-ima-dai#76
yairans
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Registration and accessing of services (previously known as managers) was moved from ui to KP
KP PR - kaltura/kaltura-player-js#477
UI PR - kaltura/playkit-js-ui#630
So changes needed to be updated also in ima-dai
solves FEC-11475
CheckLists