Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-11056): No replay button once ima postroll finished when imadai configured #61

Merged
merged 1 commit into from
Mar 7, 2021
Merged

fix(FEC-11056): No replay button once ima postroll finished when imadai configured #61

merged 1 commit into from
Mar 7, 2021

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Mar 4, 2021 •
edited
Loading

Description of the Changes

issue: The default state of imadai is IDLE so it's not "done" even it not active at all
Solution: Change the default state to DONE and move to IDLE only once there are ads
also get rid LOADED and LOADING states as these states are about the ad,
and irrelevant in imadai at all as the ad is not loaded

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans requested a review from a team March 4, 2021 20:12
@yairans yairans self-assigned this Mar 4, 2021
@yairans yairans merged commit 53bbd94 into master Mar 7, 2021
@yairans yairans deleted the FEC-11056 branch March 7, 2021 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yuvalke Yuvalke Yuvalke approved these changes

Assignees

@yairans yairans

Labels
Priority: High Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yairans @Yuvalke