feat(FEC-9988): add missing IMA DAI Parameters to buildStreamRequest #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrenMe
previously requested changes
Jun 30, 2020
|
added |
dan-ziv
reviewed
Jul 1, 2020
dan-ziv
previously approved these changes
Jul 2, 2020
|
@OrenMe , I changed the ImaDAIConfigObject jsdocs and regenerated the docs through the script. So now the new params are auto-generated. |
OrenMe
approved these changes
Jul 2, 2020
Yuvalke
approved these changes
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
from all the ticket requests only authToken was missing.
playerType and playerVersion are not supported in IMA-DAI and the last two already exist in the code
solves FEC-9988
CheckLists