Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A docker all in one usage example #143

Open
leandromoreira opened this issue Jan 6, 2023 · 3 comments
Open

A docker all in one usage example #143

leandromoreira opened this issue Jan 6, 2023 · 3 comments

Comments

@leandromoreira
Copy link

leandromoreira commented Jan 6, 2023

Hi team,

Thanks for sharing this surprising set of projects. I built a docker image and a docker-compose to provide a complete docker all-in-one usage example.

  • added an openresty docker image (containing all the dependencies)
  • split the internal server & expose it (basically extracting the controller)
  • ported (almost 1:1 🤣 ) the php to golang
  • added a ffmpeg command generating a test pattern for multi-bitrate
  • added a minimal README on how to use it

It's missing the transcoding part plus some TODOS AND for sure many other things I have missed, but it's working!

image

I'd like to know your thoughts (and any suggestions)! I also was wondering if you'd like to have this stand-alone docker usage example in here (maybe in a folder docker_example), or maybe it should keep living in an external repo.

@erankor
Copy link
Collaborator

erankor commented Jan 7, 2023

Thanks @leandromoreira, well done!

When we created the sample all-in-one setup few weeks ago, we considered providing a docker image. The main reason we didn't go with this approach, was the transcoding part. I wanted to use the existing transcoder dockerfile, since getting the dependencies right for ffmpeg may not be trivial. And, I wanted to run the transcoding dockers on-demand - for every incoming stream that needs transcoding. If the controller also runs in docker, not sure there's a reasonable way to accomplish this... if you have some ideas about this, please share :)
Either way, I'm ok with adding a sample docker compose + dockerfile for the all-in-one setup.

Providing the sample controller in Golang is also a good idea. When we started this project 3+ years ago, I wasn't familiar with Golang... so PHP was a more natural decision for me :) But I agree Golang is a better choice moving forward.

@leandromoreira
Copy link
Author

@erankor thank you for sharing your team's work :) I'm going to try to port the transcoder part as well before creating a PR right here.

@mlevkov
Copy link

mlevkov commented Feb 5, 2023

This is quite excellent. I will contribute as well. Additionally, one can deploy this with Xilinx FPGA-driven ffmpeg instances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants