Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 7 compatibility #31

Open
schmengler opened this issue Jan 25, 2018 · 1 comment
Open

PHP 7 compatibility #31

schmengler opened this issue Jan 25, 2018 · 1 comment

Comments

@schmengler
Copy link

The following issue has been found in src/KJ/Magento/Util/Comparison/Filter/Null.php:

'null' is a reserved keyword as of PHP version 7.0 and should not be used to name a class, interface or trait or as part of a namespace
@kalenjordan
Copy link
Owner

Doh! Got it thanks. Man I haven't worked on this for so long....I wonder if someone might want to PR the fix or maybe even take over the repo...?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@schmengler @kalenjordan