Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Better MachineContext Delivery #216

Open
iceBear67 opened this issue Jun 18, 2022 · 0 comments
Open

[FEAT] Better MachineContext Delivery #216

iceBear67 opened this issue Jun 18, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@iceBear67
Copy link
Member

iceBear67 commented Jun 18, 2022

In the previous version, we can receive a MachineContext when machine is being created.
But there are side-effects:

  • When Machine is created by AstralFlow (e.g Server Startup), the context void.
  • Type convertion is very disgusting

What is really annoying is the first one, for which we can't handle context easily because we'll have to store something into state and check if context is null.

Therefore, a cached context or something else is excepted to solve this problem.

@iceBear67 iceBear67 added the enhancement New feature or request label Jun 18, 2022
@iceBear67 iceBear67 added this to the 0.1.5 milestone Jun 18, 2022
@iceBear67 iceBear67 self-assigned this Jun 18, 2022
@iceBear67 iceBear67 modified the milestones: 0.1.5, Backlog Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant