Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluation seems ton only run on sequences with length < cv_max_len #21

Open
lienz opened this issue Dec 11, 2019 · 0 comments
Open

Evaluation seems ton only run on sequences with length < cv_max_len #21

lienz opened this issue Dec 11, 2019 · 0 comments

Comments

@lienz
Copy link

lienz commented Dec 11, 2019

Hi,
Thanks for providing your implementation of Conv-Tasnet. I trained a model and when I evaluated it on the test set (using run.sh) I was surprised to only see 2618 sequences evaluated (while the test set size is 3000). It seems that the AudioDataset created in evaluate.py uses the default cv_maxlen parameter (8 seconds), such that only test sequences shorter than 8 seconds are evaluated (2618 sequences). This would mean that the test SDR is not representative of how well the model performs on longer utterances. I attached the line where the AudioDataset is created.
Best regards,
Neil

dataset = AudioDataset(args.data_dir, args.batch_size,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant