Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added optional support to build arm images with oem and recovery partitions as part of LVM #25

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Added optional support to build arm images with oem and recovery partitions as part of LVM #25

merged 1 commit into from
Feb 27, 2023

Conversation

venkatnsrinivasan
Copy link
Collaborator

No description provided.

@mudler mudler requested a review from a team February 21, 2023 20:54
mudler
mudler approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@mudler mudler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good here, however I didn't tried it locally (yet). changes looks backward compatible too, so we should be good to merge

@mudler
Copy link
Member

mudler commented Feb 23, 2023

@venkatnsrinivasan at this point the default.yaml cloud config file could be saved directly into oem instead of /usr/local when lvm is enabled, wdyt?

@mudler mudler mentioned this pull request Feb 23, 2023
Closed
@venkatnsrinivasan
Copy link
Collaborator Author

@venkatnsrinivasan at this point the default.yaml cloud config file could be saved directly into oem instead of /usr/local when lvm is enabled, wdyt?

We could do that but the script also takes an optional --config file as input, maybe that should go in /oem instead of /usr/local as its doing now, being consistent with userdata in installable systems ?

@mudler
Copy link
Member

mudler commented Feb 27, 2023

@venkatnsrinivasan yup sounds good here 👍

@venkatnsrinivasan venkatnsrinivasan merged commit 95dd24d into master Feb 27, 2023
@jimmykarily jimmykarily deleted the lvm-support-for-arm-images branch February 28, 2023 16:09
@venkatnsrinivasan venkatnsrinivasan mentioned this pull request Mar 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mudler mudler mudler approved these changes

@Itxaka Itxaka Awaiting requested review from Itxaka

Assignees
No one assigned
Labels
None yet
Projects
🧙Issue tracking board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@venkatnsrinivasan @mudler