Remove elemental-cli from kairos #1422
Conversation
|
Needs a repository bump to get the newer packages which include kairos-agent run stage and the new services using kairos-agent instead of elemental |
1 similar comment
|
Needs a repository bump to get the newer packages which include kairos-agent run stage and the new services using kairos-agent instead of elemental |
|
this one: #1423 |
| @@ -10,7 +10,7 @@ SSH_USER="${SSH_USER:-kairos}" | |||
| SSHPASS="${SSH_PASS:-kairos}" | |||
| export SSHPASS | |||
| HD_SIZE="${HD_SIZE:-50000}" | |||
| INSTALL_COMMAND="${INSTALL_COMMAND:-sudo /bin/sh -c 'elemental install /dev/sda && sync'}" | |||
| INSTALL_COMMAND="${INSTALL_COMMAND:-sudo /bin/sh -c 'kairos-agent install /dev/sda && sync'}" | |||
There was a problem hiding this comment.
Isn't it true that kairos-agent install and kairos-agent manual-install can be both used to achieve the same things (are interchangeable) ? If yes, maybe we should get rid of one of the 2.
There was a problem hiding this comment.
Nothing to do with this PR though, I just had that thought.
There was a problem hiding this comment.
Basically yes, but manual install accepts a config file while install does not and expects a config to be ready in the live CD or config dirs.
We should merge both and just add a flag to override the config file.
We no longer need to link stuff as kairos-agent will try to find both names for the binaty Signed-off-by: Itxaka <[email protected]>
Signed-off-by: Itxaka <[email protected]>
Signed-off-by: Itxaka <[email protected]>
Signed-off-by: Itxaka <[email protected]>
Signed-off-by: Itxaka <[email protected]>
Signed-off-by: Itxaka <[email protected]>
Signed-off-by: Itxaka <[email protected]>
Signed-off-by: Itxaka <[email protected]>
Signed-off-by: Itxaka <[email protected]>
Signed-off-by: Itxaka <[email protected]>
Signed-off-by: Itxaka <[email protected]>
Signed-off-by: Itxaka <[email protected]>
Signed-off-by: Itxaka <[email protected]>
They store the files in different places Signed-off-by: Itxaka <[email protected]>
- machine-id should be removed to not break non systemd systems. - systemd will create it on first boot, then our yip files take care of storing it safely - /var/lib/dbus needs to be a PERSISTENT path for alpine systems using dbus, which store the machine-id in there Signed-off-by: Itxaka <[email protected]>
Signed-off-by: Itxaka <[email protected]>
Signed-off-by: Itxaka <[email protected]>
Signed-off-by: Itxaka <[email protected]>
Signed-off-by: Itxaka <[email protected]>
|
moved to #1441 |
Signed-off-by: Itxaka [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #