kairos-agent manual-install does not accept a URL to config file

[cheese]

Kairos version:

PRETTY_NAME="Debian GNU/Linux 12 (bookworm)"
NAME="Debian GNU/Linux"
VERSION_ID="12"
VERSION="12 (bookworm)"
VERSION_CODENAME=bookworm
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/"
KAIROS_IMAGE_REPO="quay.io/kairos/debian:bookworm-core-amd64-generic-v3.0.12"
KAIROS_IMAGE_LABEL="bookworm-core-amd64-generic-v3.0.12"
KAIROS_FLAVOR_RELEASE="bookworm"
KAIROS_RELEASE="v3.0.12"
KAIROS_PRETTY_NAME="kairos-core-debian-bookworm v3.0.12"
KAIROS_ARTIFACT="kairos-debian-bookworm-core-amd64-generic-v3.0.12"
KAIROS_FLAVOR="debian"
KAIROS_VARIANT="core"
KAIROS_ID="kairos"
KAIROS_VERSION="v3.0.12"
KAIROS_ID_LIKE="kairos-core-debian-bookworm"
KAIROS_VERSION_ID="v3.0.12"
KAIROS_SOFTWARE_VERSION_PREFIX="k3s"
KAIROS_GITHUB_REPO="kairos-io/kairos"
KAIROS_FAMILY="debian"
KAIROS_TARGETARCH="amd64"
KAIROS_BUG_REPORT_URL="https://github.com/kairos-io/kairos/issues"
KAIROS_HOME_URL="https://github.com/kairos-io/kairos"
KAIROS_NAME="kairos-core-debian-bookworm"
KAIROS_MODEL="generic"
KAIROS_REGISTRY_AND_ORG="quay.io/kairos"

CPU architecture, OS, and Version:

Linux localhost 6.1.0-21-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.90-1 (2024-05-03) x86_64 GNU/Linux

Describe the bug

#2424 is only partially fixed. kairos-agent manual-install still does not accept a URL to config file.

To Reproduce

Run kairos-agent manual-install http://192.168.xx.xx/90-my.yaml, kairos-agent just ignores the argument without warning or error.

Expected behavior

kairos-agent manual-install $CONFIG works as documented.

Logs

Additional context

[ci-robbot]

The issue does not have enough information to meet the project's requirements. Please provide more details about the issue. Labelled the issue with 'question' for more information.

[sdwilsh]

See also #764. Seems like this keeps breaking, so maybe a test would be helpful.

[Itxaka]

umm weird, I could not repro this with the latest agent:

[root@localhost ~]# curl http://192.168.1.3:8000/config.yaml
#cloud-config

install:
  grub_options:
    extra_cmdline: "rd.immucore.debug"

stages:
  initramfs:
    - name: "Set user and password"
      users:
        kairos:
          passwd: "kairos"
    - name: "Set hostname"
      hostname: kairos-{{ trunc 4 .Random }}

Calling agent as such:

kairos-agent --debug manual-install http://192.168.1.3:8000/
config.yaml

Output from the install:

  Config: collector.Config{
    "config_url": "http://192.168.1.3:8000/config.yaml",
    "install": collector.Config{
      "grub_options": collector.Config{
        "extra_cmdline": "rd.immucore.debug",
      },
      "poweroff": false,
      "reboot": false,
    },
    "stages": collector.Config{
      "initramfs": []interface {}{
        collector.Config{
          "name": "Set user and password",
          "users": collector.Config{
            "kairos": collector.Config{
              "passwd": "kairos",
            },
          },
        },
        collector.Config{
          "hostname": "kairos-{{ trunc 4 .Random }}",
          "name": "Set hostname",
        },
      },
    },
  },

Maybe the issue is that if the path is wrong, we dont care and continue:

like running it with an non-existant config file it doesnt make it fail:

kairos-agent --debug manual-install http://192.168.1.3:8000/
nope.yaml

It just makes it use the defaults.