Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move run-stage from elemental-cli to kairos-agent #1419

Closed
jimmykarily opened this issue May 16, 2023 · 6 comments · Fixed by kairos-io/kairos-agent#23, kairos-io/packages#231, kairos-io/kairos-docs#10 or kairos-io/kairos-agent#27
Closed

Move run-stage from elemental-cli to kairos-agent #1419

jimmykarily opened this issue May 16, 2023 · 6 comments · Fixed by kairos-io/kairos-agent#23, kairos-io/packages#231, kairos-io/kairos-docs#10 or kairos-io/kairos-agent#27
Assignees
@Itxaka
Labels
area/agent refactoring Areas of code that needs refactoring, or have a technical debt

Comments

@jimmykarily
Copy link
Contributor

jimmykarily commented May 16, 2023 •
edited
Loading

The kairos-agent is still shelling out to elemental-cli for run-stage (here and here).

The run-stage code is available in kairos-agent, we should use that instead and expose the run-stage command in kairos-agent so there no dependency on elemental-cli anymore.

Acceptance Criteria

  • kairos-agent doesn't shell out to elemental-cli anymore
  • elemental-cli is no longer installed on kairos and provider-kairos images
  • No services call elemental-cli either. (e.g. here and here)
@jimmykarily jimmykarily converted this from a draft issue May 16, 2023
@jimmykarily jimmykarily added refactoring Areas of code that needs refactoring, or have a technical debt area/agent labels May 16, 2023
@jimmykarily jimmykarily moved this from Todo 🖊 to Under review 🔍 in 🧙Issue tracking board May 16, 2023
@jimmykarily jimmykarily moved this from Under review 🔍 to Todo 🖊 in 🧙Issue tracking board May 16, 2023
@Itxaka
Copy link
Member

Itxaka commented May 16, 2023 •
edited
Loading

also docs should not mention elemental-cli anymore, for example reset docs

@Itxaka Itxaka moved this from Todo 🖊 to Under review 🔍 in 🧙Issue tracking board May 16, 2023
@Itxaka Itxaka self-assigned this May 16, 2023
@Itxaka
Copy link
Member

Itxaka commented May 17, 2023

kairos-agent not using elemental anymore -> kairos-io/kairos-agent#23

@Itxaka Itxaka linked a pull request May 17, 2023 that will close this issue
✨ Run stages directly from code instead of shelling out kairos-io/kairos-agent#23
Merged
@Itxaka
Copy link
Member

Itxaka commented May 17, 2023

Remove from services: kairos-io/packages#231

This was linked to pull requests May 17, 2023
Bump service to use kairos-agent instead of elemental kairos-io/packages#231
Merged
Remove elemental-cli from kairos #1422
Closed
@Itxaka
Copy link
Member

Itxaka commented May 17, 2023

drop elemental from kairos -> #1422

@Itxaka
Copy link
Member

Itxaka commented May 17, 2023

docs -> kairos-io/kairos-docs#10

@Itxaka Itxaka linked a pull request May 17, 2023 that will close this issue
📖 Drop references to elemental-cli kairos-io/kairos-docs#10
Merged
@Itxaka
Copy link
Member

Itxaka commented May 17, 2023

agent PR with extra flags needed for the docs update -> kairos-io/kairos-agent#27

@Itxaka Itxaka linked a pull request May 17, 2023 that will close this issue
✨ Allow adding extra cloud-init paths to run-stage kairos-io/kairos-agent#27
Merged
@github-project-automation github-project-automation bot moved this from Under review 🔍 to Done ✅ in 🧙Issue tracking board May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Itxaka Itxaka

Labels
area/agent refactoring Areas of code that needs refactoring, or have a technical debt
Projects
🧙Issue tracking board
Archived in project
Milestone
No milestone
2 participants
@Itxaka @jimmykarily