Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Use config/collector on kairos-agent ex-elemental commands #1225

Closed
mauromorales opened this issue Mar 30, 2023 · 5 comments · Fixed by kairos-io/kairos-agent#32
Closed
Assignees
Labels
enhancement New feature or request

Comments

@mauromorales
Copy link
Member

mauromorales commented Mar 30, 2023

There was recently a refactoring of the config pkg to have a more generic way to collect the different config files. This allows us to split the responsibilities of the config between Kairos specific (config pkg) and non specific (collector pkg). In the case of the commands that were transferred from elemental-cli we want to use the generic configuration.

see: #391 (comment)

User has to copy this file inside /oem because elemental will try to find stage steps there. Won't repect it here. Then the user has to install with kairos-agent manual-install with this file. Netbooting doesn't work for the same reason (elemental ignores the stages)

Acceptance criteria

  • the collector package is used for everything that needs to read cloud-config files
  • after-install hooks defined in the user config.yaml are picked up by kairos-agent and work
@mauromorales mauromorales added the enhancement New feature or request label Mar 30, 2023
@mauromorales mauromorales assigned mudler and unassigned mudler Mar 30, 2023
@jimmykarily
Copy link
Contributor

Blocking: #209

@jimmykarily jimmykarily moved this from Todo 🖊 to In Progress 🏃 in 🧙Issue tracking board Mar 31, 2023
@jimmykarily jimmykarily self-assigned this Mar 31, 2023
@jimmykarily
Copy link
Contributor

@jimmykarily jimmykarily moved this from In Progress 🏃 to Todo 🖊 in 🧙Issue tracking board Apr 3, 2023
@jimmykarily
Copy link
Contributor

Let' redefine this when this one is done: #1210
The "lifecycle" functionality will be part of kairos-agent so there will be no elemental-cli anymore.

@jimmykarily jimmykarily changed the title ✨ Use config/collector on elemental-cli ✨ Use config/collector on kairos-agent ex-elemental commands May 16, 2023
@jimmykarily jimmykarily moved this from Todo 🖊 to In Progress 🏃 in 🧙Issue tracking board May 24, 2023
@github-project-automation github-project-automation bot moved this from In Progress 🏃 to Done ✅ in 🧙Issue tracking board Jun 7, 2023
@jimmykarily
Copy link
Contributor

The after-install hooks should work now but there is a refactoring pending to consolidate all those "configs" (see discussion on the PR). I'll keep this open to redefine in planning or create a new card.

@jimmykarily jimmykarily reopened this Jun 7, 2023
@github-project-automation github-project-automation bot moved this from Done ✅ to Under review 🔍 in 🧙Issue tracking board Jun 7, 2023
@jimmykarily jimmykarily moved this from Under review 🔍 to Todo 🖊 in 🧙Issue tracking board Jun 7, 2023
@Itxaka
Copy link
Member

Itxaka commented Apr 29, 2024

I think this has been solved or there is not much reason to exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants