Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keeping scheduled task in database after exhausting all retries #480

Closed
hamid646m opened this issue Apr 18, 2024 · 4 comments
Closed

Keeping scheduled task in database after exhausting all retries #480

hamid646m opened this issue Apr 18, 2024 · 4 comments

Comments

@hamid646m
Copy link

I would like to recommend an enhancement: using a configuration to store failed tasks in the database. Here's a use-case I've encountered: for a task, I employ short retries, typically due to incorrect data. Once all retry attempts are exhausted, I receive a notification. At that point, I rectify the data and update the execution_time so the task can be reattempted. What do you think?

@kagkarlsson
Copy link
Owner

Yeah, I think that is an interesting addition to db-scheduler. I think it is about the same ideas as this: #27

@adamalexandru4
Copy link

I've managed by doing a custom FailureHandler called MaxRetriesNoDeleteFailureHandler without executionOperations.stop();. I can contribute if you want to implement in this way @kagkarlsson.

Another idea could be to implement the pause method on ExecutionOperations (I can help with this too)

@kagkarlsson
Copy link
Owner

I've managed by doing a custom FailureHandler called MaxRetriesNoDeleteFailureHandler without executionOperations.stop();

I don't think that will work. It will be considered dead at some point

You are welcome to try implementing #27. I am not sure how straight-forward it will be, there is a bit of exploration to it..

@kagkarlsson
Copy link
Owner

Closing since duplicate of #27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants