Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases for different handshake versions #13

Open
kjellwinblad opened this issue Jun 10, 2022 · 1 comment
Open

Add test cases for different handshake versions #13

kjellwinblad opened this issue Jun 10, 2022 · 1 comment

Comments

@kjellwinblad
Copy link
Contributor

There are three handshake versions undefined, 0 and 1 (see #5 (comment)). @starbelly, please correct me if I did not understand this correctly. We should add Kafka test cases and github actions for all handshake versions by extending the code in the example directory.

@starbelly
Copy link
Contributor

@kjellwinblad That's correct. With auth/8 function added to kafka_protocol that will invoke auth/7 on a auth plugin, we'll now get handshake 0 or 1. We may also get undefined from ourselves if auth/6 is invoked from kafka_protocol and we set it ourselves (to undefined).

However, we currently don't support handshake v0. See issue #8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants