Propagate connect_timeout argument to kpro API functions #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you for the PR @hairyhum |
hairyhum
force-pushed
the
kpro-connection-timeout
branch
from
9eeba9a
to
fb928ed
Compare
hairyhum
changed the title
|
Hi @hairyhum |
hairyhum
force-pushed
the
kpro-connection-timeout
branch
from
fb928ed
to
d70fc87
Compare
…t` arg A number of kpro connection functions support a timeout argument which is not provided by brod functions. This makes it use a default timeout of 5 seconds. Make sure brod and brod_utils functions use the connect_timeout client config for this argument
hairyhum
force-pushed
the
kpro-connection-timeout
branch
from
d70fc87
to
3e4f590
Compare
|
sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of
kproconnection functions support atimeoutargumentwhich is not provided by
brodfunctions.This makes it use a default timeout of 5 seconds.
Make sure
brodandbrod_utilsfunctions usethe
connect_timeoutclient config for this argument