-
Notifications
You must be signed in to change notification settings - Fork 31
Conversation
ritz078
commented
Jun 24, 2016
@@ -3,6 +3,9 @@ import React from 'react'; | |||
import VSplit from './vsplit'; | |||
import HSplit from './hsplit'; | |||
import SplitPane from '@kadira/react-split-pane'; | |||
import FuzzySearch from 'react-fuzzy'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like to move search component into a separate component and container by moving all these code out from the layout. Like I did for shortcuts_help.
And then simply use them inside the routing code. See: https://github.com/jtangelder/sass-loader
); | ||
return { | ||
...propShortCuts, | ||
stories: api.stories, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need these two?
Or do we need any of these changes?
@ritz078 This is great. Love this. |
@arunoda done. |
@@ -27,7 +27,12 @@ export default function (domNode, provider) { | |||
...uiModule.reducers, | |||
}); | |||
|
|||
const reduxStore = createStore(reducer); | |||
const reduxStore = createStore(reducer, ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you submit this as another PR.
When I run the example, it's using some default font in the browser. Is it possible to use the fonts we used here: https://github.com/kadirahq/storybook-ui/blob/master/src/modules/ui/components/theme.js#L2 |
This is great. Thanks. |