Skip to content
This repository has been archived by the owner on Nov 10, 2017. It is now read-only.

Added fuzzy search #7

Merged
merged 6 commits into from
Jun 27, 2016
Merged

Added fuzzy search #7

merged 6 commits into from
Jun 27, 2016

Conversation

ritz078
Copy link
Contributor

@ritz078 ritz078 commented Jun 24, 2016

screen shot 2016-06-24 at 10 02 36 pm

@@ -3,6 +3,9 @@ import React from 'react';
import VSplit from './vsplit';
import HSplit from './hsplit';
import SplitPane from '@kadira/react-split-pane';
import FuzzySearch from 'react-fuzzy';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like to move search component into a separate component and container by moving all these code out from the layout. Like I did for shortcuts_help.

And then simply use them inside the routing code. See: https://github.com/jtangelder/sass-loader

);
return {
...propShortCuts,
stories: api.stories,
Copy link
Contributor

@arunoda arunoda Jun 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need these two?
Or do we need any of these changes?

@arunoda
Copy link
Contributor

arunoda commented Jun 25, 2016

@ritz078 This is great.
Once we okay with the above comments, we can proceed on this.

Love this.

@ritz078
Copy link
Contributor Author

ritz078 commented Jun 25, 2016

@arunoda done.

@@ -27,7 +27,12 @@ export default function (domNode, provider) {
...uiModule.reducers,
});

const reduxStore = createStore(reducer);
const reduxStore = createStore(reducer, (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you submit this as another PR.

@arunoda
Copy link
Contributor

arunoda commented Jun 25, 2016

When I run the example, it's using some default font in the browser. Is it possible to use the fonts we used here: https://github.com/kadirahq/storybook-ui/blob/master/src/modules/ui/components/theme.js#L2
screen shot 2016-06-25 at 2 43 43 pm

@ritz078 ritz078 changed the title Added redux devtools support and fuzzy search Added fuzzy search Jun 25, 2016
@arunoda
Copy link
Contributor

arunoda commented Jun 27, 2016

This is great. Thanks.

@arunoda arunoda merged commit 4340c80 into storybook-eol:master Jun 27, 2016
ndelangen pushed a commit that referenced this pull request Apr 2, 2017
ndelangen pushed a commit that referenced this pull request Apr 10, 2017
ndelangen pushed a commit that referenced this pull request Apr 10, 2017
ndelangen pushed a commit that referenced this pull request Apr 10, 2017
ndelangen added a commit that referenced this pull request Apr 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants