This repository has been archived by the owner on Nov 10, 2017. It is now read-only.
fix(ui/components/left_panel): use links for accessibility #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks pretty cool for me. |
frassinier
reviewed
Sep 29, 2016
| onClick={this.fireOnKind.bind(this, kind)} | ||
| > | ||
| <li key={kind}> | ||
| <a style={style} onClick={onClick}> |
There was a problem hiding this comment.
Should <a href title="{Open ${kind}}" style={ be better?
There was a problem hiding this comment.
Opened a PR but we need to verify whether improve accessibility before merging
#44
ndelangen
pushed a commit
that referenced
this pull request
Apr 10, 2017
* implement multiple docs navigation * change docs data strutcure * styling * fix routings when responsive view * Add some real docs. * Add all basics docs. * Add management features section. * Change style. * Change the header to add Storybook Hub. * Chaneg nav styles a bit. * fix some minor issues * fix storybook failing * change docs page title according to the categoryh * Add the comment screenshot.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix storybookjs/storybook#505