This repository has been archived by the owner on Nov 10, 2017. It is now read-only.
Render all the panels but none selected panels has display:none #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When only the selected panel rendered, when panels are changed they always gets unmounted recreated and re-mounted. This will avoid it and once a panel is mounted at the begining it will be there forever. So the changes made to a panel is not lost when changing panels.
roonyh
force-pushed
the
avoid-re-mounting-panels
branch
from
117c550 to
d6ed1d7
Compare
|
@mnmtanish have you done a release? |
|
Just released |
ndelangen
pushed a commit
that referenced
this pull request
Apr 2, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When only the selected panel rendered, when panels are changed they always gets unmounted recreated and re-mounted. This will avoid it and once a panel is mounted at the beginning it will be there forever. So the changes made to a panel is not lost when changing panels.
This is how it was done originally, but I changed it here without realizing what it did :( This PR undo it.