This repository has been archived by the owner on Nov 10, 2017. It is now read-only.
Add missing dependency fixes #34 #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arunoda shall I merge this one now? Need it for RN Storybook. |
|
This should be a peerDependancy |
thani-sh
force-pushed
the
add-react-dom-dep
branch
from
038bb7d to
e0c8863
Compare
|
Yeah, just updated the PR to make it a peer dependency. |
| @@ -42,7 +42,8 @@ | |||
| "sinon": "^1.17.3" | |||
| }, | |||
| "peerDependencies": { | |||
| "react": "^0.14.7 || ^15.0.0" | |||
| "react": "^0.14.7 || ^15.0.0", | |||
| "react-dom": "^15.0.0" | |||
There was a problem hiding this comment.
Add support for react-dom for 0.14.x as well.
|
@arunoda updated the range |
|
Go for it and do a release. |
|
Released |
ndelangen
pushed a commit
that referenced
this pull request
Apr 10, 2017
Use the branch url for notes addon
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, react-storybook has this as a dependency.
That's why it didn't surface earlier.