Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude initial number interaction as a user action #33

Closed
nvllz opened this issue Feb 27, 2023 · 2 comments
Closed

Exclude initial number interaction as a user action #33

nvllz opened this issue Feb 27, 2023 · 2 comments

Comments

@nvllz
Copy link
Contributor

nvllz commented Feb 27, 2023

If you try to replace an initial number by selecting a cell and clicking on any number in the bottom bar, it won't affect the number because they are not overwritable. But it still counts as a user action. You can see this by trying to undo your input, which will try to undo changes that were never made to the initial numbers every time you tap Undo.

To reproduce:

  1. Start a new game and fill any empty cell with any number on the grid
  2. Select any initial digit cell and try to overwrite it with a random digit x times (it won't affect the cell)
  3. Tap the Undo button

You are expecting the button to undo a visible change made in the first step, and instead you need to tap the Undo button x+1 times to undo a visible action. To fix this, make the interaction with the initial numbers not count as a user action.

@kaajjo kaajjo closed this as completed in 1f24497 Feb 28, 2023
@nvllz
Copy link
Contributor Author

nvllz commented Mar 9, 2023

Looks like it didn't fix the problem.

@kaajjo
Copy link
Owner

kaajjo commented Mar 10, 2023

yep, not fixed in cell first input mode

@kaajjo kaajjo reopened this Mar 10, 2023
@kaajjo kaajjo closed this as completed in eea0d66 Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants