Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1alpha2 cut release #30

Closed
ffromani opened this issue Feb 6, 2023 · 7 comments
Closed

v1alpha2 cut release #30

ffromani opened this issue Feb 6, 2023 · 7 comments

Comments

@ffromani
Copy link
Contributor

ffromani commented Feb 6, 2023

we merged all the relevant PRs (#29 #28 #26 #25) and testbed PRs are looking good (k8stopologyawareschedwg/resource-topology-exporter#157 kubernetes-sigs/scheduler-plugins#488)
so we can cut a release.

The only thing left is to review the k8s standard recommendations to learn if the new tag should be 0.1.0 or 0.0.14

@ffromani
Copy link
Contributor Author

ffromani commented Feb 6, 2023

/cc @swatisehgal

@fmuyassarov
Copy link

That would be good to have.

@fmuyassarov
Copy link

@ffromani when do you expect to add v1beta1 API? If very soon, would it make sense to hold the release until then ?

@ffromani
Copy link
Contributor Author

ffromani commented Feb 6, 2023

v1beta1 work is at early planning stage and I don't think is helpful to hold the release until then. Unless there are clear reasons to change course, I prefer a "release early, release often" approach and many gradual improvements over a "let's change the world in one go" approach.

@swatisehgal
Copy link
Contributor

we merged all the relevant PRs (#29 #28 #26 #25) and testbed PRs are looking good (k8stopologyawareschedwg/resource-topology-exporter#157 kubernetes-sigs/scheduler-plugins#488) so we can cut a release.

The only thing left is to review the k8s standard recommendations to learn if the new tag should be 0.1.0 or 0.0.14

I am in the favor of moving to 0.1.0 as that would allow us to provide a clear indication that 0.1.0 onwards corresponds to major a change (i.e. graduation of the the API to v1alpha2). Incrementing of the minor versions should correspond to minor changes.

I investigated a few projects that are not directly tied to Kubernetes release cycle e.g. projects under https://github.com/kubernetes-sigs. I arrived to the conclusion that there is no common pattern between the projects that are not tied to Kubernetes releases and typically make a call autonomously on release cadence and release iteration structure.

If I were to go back in time, I would have probably cut a v0.1.0 release when we reached at a reasonable "stable" state
of v1alpha1. That would have allowed us to go to v0.2.0 now with the graduation of API to v1alpha2 version. But, let's do the best we can now :)

v1beta1 work is at early planning stage and I don't think is helpful to hold the release until then. Unless there are clear reasons to change course, I prefer a "release early, release often" approach and many gradual improvements over a "let's change the world in one go" approach.

I agree. It is time to cut release and recognize this point in the API as a milestone!

@ffromani
Copy link
Contributor Author

ffromani commented Feb 7, 2023

@swatisehgal thanks for checking! I'm also in favor of tagging 0.1.0. Fully agree to all your musings.

@ffromani
Copy link
Contributor Author

ffromani commented Feb 7, 2023

done! https://github.com/k8stopologyawareschedwg/noderesourcetopology-api/releases/tag/v0.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants