Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8SSAND-1470 ⁃ Add static checking to unit tests in GHA #325

Closed
burmanm opened this issue Apr 21, 2022 · 0 comments · Fixed by #266
Closed

K8SSAND-1470 ⁃ Add static checking to unit tests in GHA #325

burmanm opened this issue Apr 21, 2022 · 0 comments · Fixed by #266
Assignees
Labels
enhancement New feature or request

Comments

@burmanm
Copy link
Contributor

burmanm commented Apr 21, 2022

What is missing?
We do not have any staticchecking that verifies that PRs do not forget to check some basic stuff (such as errors returned by functions). Adding golangci-lint seems reasonable as its used in many projects (it bundles many different linters and allows to check which ones are ran).

Why do we need it?
staticchecks, if not too rigorous, can catch some easy-to-miss bugs.

Environment

  • Cass Operator version:

    Insert image tag or Git SHA here

    **Anything else we need to know?**:

┆Issue is synchronized with this Jira Task by Unito
┆friendlyId: K8SSAND-1470
┆priority: Medium

@burmanm burmanm added the enhancement New feature or request label Apr 21, 2022
@sync-by-unito sync-by-unito bot changed the title Add static checking to unit tests in GHA K8SSAND-1470 ⁃ Add static checking to unit tests in GHA Apr 21, 2022
@burmanm burmanm self-assigned this Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant