[BUG] container images are built without the commit SHA

[maiqueb]

Describe the bug
When I check the commit SHA from a container image provided by this repo's package, I don't see the commit SHA from which the container image was built.

This NONE is the default value specified in the container image.

Expected behavior
The command below should output the commit ID from which the container image was built.

To Reproduce
Steps to reproduce the behavior:

skopeo inspect docker://ghcr.io/k8snetworkplumbingwg/multus-dynamic-networks-controller:latest-amd64 -f '{{ index .Labels "multi.GIT_SHA" }}'
NONE

Environment:

• multus-dynamic-networks-controller version: N/A
• Kubernetes version (use kubectl version): N/A
• Network-attachment-definition: N/A
• OS (e.g. from /etc/os-release): N/A
• Controller configuration (criSocketPath / multusSocketPath): N/A
• Kernel (e.g. uname -a): N/A
• Others: N/A

Additional info / context
Add any other information / context about the problem here.

[maiqueb]

Failing w/

[Invalid workflow file: .github/workflows/image-push.yaml#L47](https://github.com/k8snetworkplumbingwg/multus-dynamic-networks-controller/actions/runs/3473197429/workflow)
The workflow is not valid. .github/workflows/image-push.yaml (Line: 47, Col: 13): A sequence was not expected

in this github action.

[maiqueb]

Still not working ...

skopeo inspect docker://ghcr.io/k8snetworkplumbingwg/multus-dynamic-networks-controller:latest-amd64 -f '{{ index .Labels "multi.GIT_SHA" }}'
NONE

[oshoval]

Maybe worth to take a look here docker/build-push-action#557 ?
unless it is the same.. (worth to make sure indent and such)

Imo best just to take this and adapt your code to

      - name: Build and Push
        if: github.event_name != 'pull_request'
        uses: docker/build-push-action@v2
        with:
          context: .
          platforms: linux/amd64,linux/arm64,linux/arm/v7
          push: true
          target: production
          tags: ${{ env.docker_tags }}
          build-args: |
            commit_hash=${{ env.git_commit_hash }}
            commit_date=${{ env.git_commit_date }}

it can be for example the env.git_commit_hash that fixes it

[maiqueb]

Fixed in #80 .