We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug An update to an existing attachment is currently being accepted, and treated as the following sequence of operations (in this order):
Expected behavior The controller should reject this operation, logging this.
To Reproduce Steps to reproduce the behavior:
--- apiVersion: "k8s.cni.cncf.io/v1" kind: NetworkAttachmentDefinition metadata: name: macvlan1-config spec: config: '{ "cniVersion": "0.4.0", "plugins": [ { "type": "macvlan", "capabilities": { "ips": true }, "master": "eth1", "mode": "bridge", "ipam": { "type": "static" } }, { "type": "tuning" } ] }' --- apiVersion: v1 kind: Pod metadata: name: macvlan1-worker1 annotations: k8s.v1.cni.cncf.io/networks: '[ { "name": "macvlan1-config", "ips": [ "10.1.1.11/24" ] } ]' labels: app: macvlan spec: containers: - name: macvlan-worker1 image: centos:8 command: ["/bin/sleep", "10000"] securityContext: privileged: true
{ "name": "macvlan1-config", "ips": [ "10.1.1.11/24" ], "interface": "net1" }
Environment:
kubectl version
criSocketPath
multusSocketPath
uname -a
Additional info / context I wonder if an event should be thrown for this vs only logging the error.
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
Describe the bug
An update to an existing attachment is currently being accepted, and treated as the following sequence of operations (in this order):
Expected behavior
The controller should reject this operation, logging this.
To Reproduce
Steps to reproduce the behavior:
Environment:
kubectl version
): N/AcriSocketPath
/multusSocketPath
): N/Auname -a
): N/AAdditional info / context
I wonder if an event should be thrown for this vs only logging the error.
The text was updated successfully, but these errors were encountered: