New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ownerReference to secrets #52

Closed

sp-yduck opened this issue Jul 29, 2023 · 0 comments · Fixed by #64

Assignees

Labels

good first issue

Collaborator

sp-yduck commented Jul 29, 2023

the secrets storing proxmox auth credentials should have ownerReference (for ProxmoxCluster) so that they can be removed properly when owner object is deleted (reference : https://cluster-api.sigs.k8s.io/reviewing?highlight=owner#owner-references)
https://github.com/sp-yduck/cluster-api-provider-proxmox/blob/1d70f39ce5661405f4069e477aa1fa20ee6598f9/cloud/scope/clients.go#L35-L45

sp-yduck added the good first issue label

sp-yduck self-assigned this

This was referenced Aug 9, 2023

set ownerref to secret #62

Merged

release v0.3.0 #64

Merged

sp-yduck closed this as completed in #64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment