Add ServiceAccount for svclb pods #6253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For 1.24 and earlier, the svclb pods need a ServiceAccount so that we can allow their sysctls in PSPs Signed-off-by: Brad Davidson <[email protected]>
Codecov ReportBase: 9.76% // Head: 9.75% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #6253 +/- ##
=========================================
- Coverage 9.76% 9.75% -0.02%
=========================================
Files 139 139
Lines 10130 10142 +12
=========================================
Hits 989 989
- Misses 8937 8949 +12
Partials 204 204
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
briandowns
approved these changes
Oct 10, 2022
dereknola
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
For compat with 1.24 and earlier, the svclb pods need a ServiceAccount so that we can allow their sysctls in PSPs.
Note that the pod doesn't mount the SA, we just need it so that we can allow the pod to use the PSP via RBAC.
Types of Changes
enhancement
Verification
No change here; will verify on RKE2 side where PSPs are enabled
Testing
Linked Issues
User-Facing Change
Further Comments