[release-1.24] Backports for 2022-10 #6227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brad Davidson <[email protected]>
... and drop legacy ClusterID support. Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
If CCM and ServiceLB are both disabled, don't run the cloud-controller-manager at all; this should provide the same CLI flag behavior as previous releases, and not create problems when users disable the CCM but still want ServiceLB. Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
We should be reading from the hijacked bufio.ReaderWriter instead of directly from the net.Conn. There is a race condition where the underlying http handler may consume bytes from the hijacked request stream, if it comes in the same packet as the CONNECT header. These bytes are left in the buffered reader, which we were not using. This was causing us to occasionally drop a few bytes from the start of the tunneled connection's client data stream. Signed-off-by: Brad Davidson <[email protected]>
The kubelet port can be overridden by users; we shouldn't assume its always 10250 Signed-off-by: Brad Davidson <[email protected]>
CA cert will never be equal to the serving-kube-apiserver cert so it seems like a copy-paste error. Signed-off-by: Vladimir Pouzanov <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
Replace ETCD-JOIN-STABLE-SECOND with ETCD-JOIN-LATEST-FIRST. We don't support joining down-level servers to existing clusters, as the new down-level server will try to deploy older versions of the packaged manifests. Signed-off-by: Brad Davidson <[email protected]>
brandond
force-pushed
the
backports_release-1.24
branch
from
23ee1c9
to
559271a
Compare
Codecov ReportBase: 9.71% // Head: 9.73% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## release-1.24 #6227 +/- ##
===============================================
+ Coverage 9.71% 9.73% +0.01%
===============================================
Files 138 140 +2
Lines 10064 10130 +66
===============================================
+ Hits 978 986 +8
- Misses 8887 8942 +55
- Partials 199 202 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
rbrtbnfgl
approved these changes
Oct 7, 2022
dereknola
approved these changes
Oct 7, 2022
Taint the first node so that the helm job doesn't run on it. In a real cluster the helm job would eventually succeed once all the servers were upgraded and had the new chart tarball. Signed-off-by: Brad Davidson <[email protected]>
|
Drone is not currently syncing PRs, but other tests are green and a local CI run succeeds. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
error dialing backenderrors in apiserver network proxy #6216Types of Changes
Backports
Verification
See linked issues
Testing
Linked Issues
User-Facing Change
Further Comments