Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add journalctl logs to E2E tests #6224

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Add journalctl logs to E2E tests #6224

merged 1 commit into from
Oct 7, 2022

Conversation

dereknola
Copy link
Member

@dereknola dereknola commented Oct 6, 2022 •
edited
Loading

Signed-off-by: Derek Nola [email protected]

This PR is taking good parts from #6214.

Proposed Changes

  • Improved E2E failure logging. Now when a VM fails to start the K3s service, the tests will attempt to record the journalctl logs from that failure before cleanup.
  • Added a reusable workflow for building K3s in GH actions, DRY!
  • Reduce triggering of Integration tests, only run when K3s code is changed and integration tests are changed, ignore when other test types change.

Types of Changes

Test improvements

Verification

CI Passes

Testing

Linked Issues

N/A internal CI changes only

User-Facing Change

Further Comments

@dereknola dereknola requested a review from a team as a code owner October 6, 2022 19:32
@dereknola dereknola merged commit 3b4bbca into k3s-io:master Oct 7, 2022
@dereknola dereknola deleted the journalctl_e2e branch October 18, 2022 16:39
@cguertin14 cguertin14 mentioned this pull request Oct 27, 2022
Merged
@dereknola dereknola mentioned this pull request Dec 7, 2022
Merged
@dereknola dereknola mentioned this pull request Jan 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandowns briandowns briandowns approved these changes

@brandond brandond brandond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dereknola @brandond @briandowns